Skip to content

Fixed an issue with the bot interface to keep the lease in case both server and client are in PENDING state instead of dropping it. The lease used to get dropped before client responded so now server will wait for a state change instead.

Marios Hadjimichael requested to merge mhadjimichael/buildgrid:marios/bot-interface-wait-state-change into master

Description

Fixed an issue with the bot interface to keep the lease in case both server and client are in PENDING state instead of dropping it. The lease used to get dropped before client responded so now server will wait for a state change instead.

Updated tests/integration/bots_service to no longer consider server-client pending-pending states out of sync; it is the case that the server is waiting on a response. We might want to include a timeout

Additional test for bot PENDING->ACTIVE transitions while service is PENDING

Changes proposed in this merge request:

  • If both server and client are pending, wait for a state change rather than deleting the lease
  • Updated unit tests

This merge request, when approved, will close issue/bug:

The client takes some time actually respond through the network which means the state update will not be immediately available.

Merge request reports