Skip to content
Snippets Groups Projects

Fixed an issue with the bot interface to keep the lease in case both server and client are in PENDING state instead of dropping it. The lease used to get dropped before client responded so now server will wait for a state change instead.

Description

Fixed an issue with the bot interface to keep the lease in case both server and client are in PENDING state instead of dropping it. The lease used to get dropped before client responded so now server will wait for a state change instead.

Updated tests/integration/bots_service to no longer consider server-client pending-pending states out of sync; it is the case that the server is waiting on a response. We might want to include a timeout

Additional test for bot PENDING->ACTIVE transitions while service is PENDING

Changes proposed in this merge request:

  • If both server and client are pending, wait for a state change rather than deleting the lease
  • Updated unit tests

This merge request, when approved, will close issue/bug:

The client takes some time actually respond through the network which means the state update will not be immediately available.

Merge request reports

Pipeline #28130716 passed

Test coverage 71.71% (0.06%) from 1 job

Closed by Marios HadjimichaelMarios Hadjimichael 6 years ago (Aug 20, 2018 7:19pm UTC)

Merge details

  • The changes were not merged into .

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading