Skip to content

Fix CAS issues on Python 3.5

Carter Sande requested to merge bloomberg/buildgrid:csande/cas-3.5 into master

Description

CAS currently uses a couple of minor Python features (formatted string literals, passing pathlib.Path objects to os functions) that are only available in Python 3.6 and newer. This PR replaces these with their Python 3.5-compatible equivalents.

Changes proposed in this merge request:

  • In DiskStorage, convert Path objects to strings before using them
  • Replace f"..." literals in test cases with "...".format()

Related issue

See #40 (closed) for discussion regarding whether or not to support Python 3.5 in BuildGrid. (Depending on the discussion there, we might ultimately decide not to merge this.)

Merge request reports