Skip to content
Snippets Groups Projects

Do not return data on errors

Merged Cal Pratt requested to merge cpratt34/no-res-on-error into master

When returning errors, we had previously been returning an empty proto payload back as well. This leads to confusing errors and is not in-line with expected usage of APIs.

Merge request reports

Pipeline #1395885052 passed with warnings

Pipeline passed with warnings for 5c9a1831 on cpratt34/no-res-on-error

Test coverage 88.65% (0.05%) from 1 job
Approval is optional

Merged by Cal PrattCal Pratt 5 months ago (Jul 31, 2024 7:14pm UTC)

Merge details

  • Changes merged into with 5c9a1831.
  • Deleted the source branch.

Pipeline #1395903671 failed

Pipeline failed for 5c9a1831 on master

Test coverage 88.66% (0.05%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading