Skip to content

Metric renaming overhaul

Cal Pratt requested to merge cpratt34/metric-rename into cpratt34/implicit-instance-metrics

Adding this into the existing MR branch in !1083 (merged)

Updates:

  • Merged the existing decorators for servicer endpoints into an @rpc decorator.
    • Added new tags to all metrics, instance, service, and method.
    • Added a new decorator for network ingress/egress to servicer methods.
  • Refactor the timing metrics to support posting on exceptions.
    • Exception name will be applied as a tag to non-rpc metrics
    • GRPC status code will be applied to rpc metrics
  • Refactored metrics on storages to include the storage type as a tag storage
    • Will allow more easily comparing storage types and latency breakdowns per api.
  • Removed redundant metrics
    • Where possible we can now use the rpc.duration.ms as it attaches a status code to the metric.
    • e.g. The count component of the timer can be used to calculate successful vs non-successful action-cache hits

Merge request reports