Skip to content
Snippets Groups Projects

Do not crash the cleaner when storage delete fails

Merged Shivam Bairoliya requested to merge sbairoliay/do_not_crash into master
All threads resolved!

Description

S3 can result in 504 errors when experiencing issues, this updates the logic to not crash in the case and have the correct metrics when the delete does not go through

There is also a small bug fix that I noticed while editing this code

Changes proposed in this merge request:

  • Whenever the storage bulk delete call fails due to a storage exception log the error and not crash
Edited by Shivam Bairoliya

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Zehao Chen
  • Shivam Bairoliya resolved all threads

    resolved all threads

  • added 2 commits

    • 7ae48d1e - Do not crash the cleaner when storage delete fails
    • 907ed87a - small bug in caclculating digests_to_delete

    Compare with previous version

  • added 2 commits

    • b4ab76ee - Do not crash the cleaner when storage delete fails
    • 7218cd9d - small bug in caclculating digests_to_delete

    Compare with previous version

  • Zehao Chen
  • Zehao Chen
  • Zehao Chen
  • Shivam Bairoliya resolved all threads

    resolved all threads

  • added 2 commits

    • 34c93513 - Do not crash the cleaner when storage delete fails
    • dcde612b - small bug in caclculating digests_to_delete

    Compare with previous version

  • Zehao Chen
  • Zehao Chen approved this merge request

    approved this merge request

  • Jeremiah Bonney approved this merge request

    approved this merge request

  • Shivam Bairoliya resolved all threads

    resolved all threads

  • added 1 commit

    • da687d2b - Update log lines for better visibility

    Compare with previous version

  • Shivam Bairoliya enabled an automatic merge when all merge checks for da687d2b pass

    enabled an automatic merge when all merge checks for da687d2b pass

  • Please register or sign in to reply
    Loading