Skip to content

trexe: Support ro or rw input paths

Zehao Chen requested to merge zchen723/trexe-input-mode into master

Before raising this MR, consider whether the following are required, and complete if so:

  • Unit tests
  • Metrics
  • Documentation update(s)

Description

Allow trexe to upload input trees with ro or rw permission. Only unix_mode of regular files are affected, not directories.

With CLI, it will be local/path:remote/path:ro. This is similar to docker run -v.

With a config file, it will be

[input-path]
local = "/local/path"
remote = "remote/path"
file-permission = "rw"

Changes proposed in this merge request:

  • Parse the optional permission setup
  • Mask the file permission of input trees if needed
  • If the permission is not configured, for backward compatibility, unix_mode will not be captured (and changed)
  • Refactor File and FileNodeMetaData classes to support the new property during merging

Validation

Will also add an e2e test after MR being merged.

Edited by Zehao Chen

Merge request reports