Add some free drumkits, hi hats choked when mapping mode, start from note 0 in scanning folder mode

fidzrequested to merge
arnaudfi/drumkv1gen:master into master

Hi,

Thanks for this software, I have made some changes on my own version :

  • Add 4 drumkits (with mapfiles) from http://machines.hyperreal.org to get_free_kits.sh
  • Add a script get_free_kits_musicradar.sh to get drumkits from musicradar (with mapfiles)
  • When using "mapping file" mode, hihats (midi 42, 44, 46) are in group 1 : open hihat is choked when hitting pedal hihat or closed hihat.
  • When using "scanning folder" mode, start from key=0 (36 in the original version).

I am not a good programmer (I know just a bit of shell, and I did some java when I was student 18 years ago) and I didn't manage to implement the choice of the starting note when doing a scanning folder mode. I change to 0 because I think this mode is usefull when you work with one track per instrument and so one drumkv1 per instrument (one for kick, one for snare, one for hihats...). When you do that you want all the kick sound of your sample library in the plugin drumkv1 on your kick track, all the snare sound on the snare track... and you just choose the note corresponding to the sound you like, so no need to start from 36. 0 seems better to me because you can put 128 sounds. => Of course this is just my point of view, please dont hesitate to refuse any change I am proposing.

Thanks again, hope you will like it 😄

Merge request reports