Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • Server Server
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 264
    • Issues 264
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 35
    • Merge requests 35
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • 2009Scape2009Scape
  • ServerServer
  • Merge requests
  • !822

Corp Bugfixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Ceikry requested to merge grave-zonerestriction into master Sep 17, 2022
  • Overview 3
  • Commits 2
  • Pipelines 3
  • Changes 4

What have you done in this MR?

  • Corp now correctly only destroys summons that have entered the boss room proper
  • Corp destroys summons after exactly 10 seconds (source is cited on the line of code)
  • Corp now repeatedly fullheals if there's no players active in the room (meaning you cannot just cannon it to death)
  • You no longer get a grave if you die in the corp boss room.

Testers: Check all of the above please :)

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits, I did not edit any JSON files by hand (MR will be rejected if there are manual JSON edits).

  • I acknowledge that this contribution will be released under the AGPL license.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: grave-zonerestriction