#707: Added exemption for staff accts from daily acct login limit

Byterequested to merge
ByteEngineer/2009scape:707-staff-accts-login-limit-exempt into master

What have you done in this MR?

  • Added exemption for staff accounts to not abide by daily account limit

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:
  • I have tested these changes thoroughly.
  • This requires extra testing due to changes to architecture or other similarly risky changes.
  • I used the Thanos Tool for any JSON edits, I did not edit any JSON files by hand (MR will be rejected if there are manual JSON edits).
  • I acknowledge that this contribution will be released under the AGPL license.

I ran a server with auth and persistent accounts enabled. I ran a db server as well.

I created 3 regular accounts. I was able to login to all of them. I created a 4th regular account. I could not login, as I had exceeded my daily account limit of 3. I turned off the server and went to the db. I edited the 4th user to have staff permissions "rights=1". I then started the server up and tried to login with all 3 regular users again. All were able to login with auth enabled. I then tried to login with the edited 4th user and I was able to login. This means the 4th user was treated as a staff account and bypassed the daily login limit successfully. I quickly created and edited a 5th user to also be a staff account. The 5th user was also able to login.

Finally, I quickly tried changing the order of logins. I logged in with both staff accounts (4 and 5) first, and I was still able to then login to all 3 regular accounts after.

Closes #707 (closed)

Merge request reports