Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • Server Server
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 267
    • Issues 267
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 53
    • Merge requests 53
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • 2009Scape2009Scape
  • ServerServer
  • Merge requests
  • !800

Lost City Update

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged MatthewGould123 requested to merge MatthewGould123/2009scape:lost-city-conversion into master Sep 09, 2022
  • Overview 4
  • Commits 18
  • Pipelines 3
  • Changes 18

What have you done in this MR?

From Prior MR

  • Convert Lost City quest from Java to Kotlin
  • Fixed certain weapons not being properly locked behind Lost City quest
  • Fixed bugs in quest level requirements
  • Zanaris entry fairy ring now returns players to the shed when they use it
  • Warrior dialogue missing lines and facial expressions added in

Continued:

  • Fixed warrior dialogue issue. You can now start the lost city quest.
  • Fairy rings are now enabled when the lost city quest is complete and you are wielding a dramen staff or lunar staff

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits, I did not edit any JSON files by hand (MR will be rejected if there are manual JSON edits).

  • I acknowledge that this contribution will be released under the AGPL license.

Finishes up feedback from !736 (comment 1069909959)

Testers:

  • You should be able to talk to the warrior and start the lost city quest.
  • You should be able to visit zanaris if wielding a dramen/lunar staff and when using the fairy ring inside of zanaris, it should tp you back to the shed.
Edited Sep 09, 2022 by Ryan
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: lost-city-conversion