Charged DFS stat adjustments

DebbySaurusrequested to merge
DebbySaurus/2009scape:DFSadjustments into master

What have you done in this MR?

A fully charged dragonfire shield has way too high stats, almost double of what it should be. I fixed them to be authentic to '09.

Apparently the code for this item already handles the stats increase per charge, which got added on top of the item config stats, so I Adjusted those accordingly.

Added summon defense bonus to the stat bonus per charge.

Source used for stats Among other videos around that era.

Intended stats of a fully charged DFS should be:

  • -10 magic atk.

  • -5 range atk.

  • +70 stab def.

  • +75 slash def.

  • +72 crush def.

  • +10 magic def

  • +72 summon def.

  • +7 STR

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits, I did not edit any JSON files by hand (MR will be rejected if there are manual JSON edits).

  • I acknowledge that this contribution will be released under the AGPL license.

Edited by DebbySaurus

Merge request reports