Fremennik Easy Diary

skelsoftrequested to merge
(removed):crash-fremennik-easy-diary into master

Here's something from RW's cutting room floor, one of the last pieces of Phil work. I had to bash the last quarter of it together myself.

As such, it comes with a few caveats, that I'm sure you smart fellas can iron out properly and correctly.

  • PickUpEvent Event Hook created, for events that need to fire when player picks up a specific item

  • All currently implemented Diary tasks where the player must pick up items have been converted to use the new PickUpEvent event hook (Fremennik, Karamja diaries) and removed from PickupHandler.kt

  • Hunting Expert (Rellekka) NPC dialogue handling removed from HuntingExpert.java dialogue file (completely different NPC)

  • new zone created for the windswept tree (highest tree in the Fremennik area task) for its diary task

  • Rough dialogue created for obtaining your completed diary reward from Council Worker

  • The Fremennik Easy Diary should now be fully completable, and the Fremennik sea boots 1 can now be obtained

  • Requires npc_spawn.json data from MR !632 (merged) in order to be fully complete (can't have the JSONs regress)

The following further development and polish is needed for this to be fully "complete":

  • Hunting Expert (Relekka Polar Hunter) NPC (ID 5112) in the Polar Hunter area in Relekka has placeholder dialogue TODO: correct dialogue

  • Otto Godblessed Easy Diary task added to his already placeholder dialogue for barbfishing TODO: move to appropriate point when rest of Barbarian training is added

  • "View the rewards in the Barbarian Assault tutorial" Easy Diary task, due to Ryan still not implementing the minigame, has been moved to Cain's main dialogue as it tells you how long it has been since he said he would implement it. TODO: Move this to appropriate dialogue step once Barbarian Assault tutorial has been implemented

  • "Fish off of one of Rellekka's piers" Easy Diary task half-completed, only checks for the Cage/Harpoon spot on the northeasternmost dock. TODO: proper region check for all fishing spots in the vicinity of Rellekka

  • Council worker Diary dialogue roughly cobbled together so Fremennik sea boots 1 are obtainable if you lose them TODO: someone please do the proper dialogue for this so the rewards can be properly received and checked as i have no idea how to do it

Are there any tricky things testers should keep an eye out for?

  • just make sure you can complete the fremennik easy diary and get a pair of boots from the Council Workman
  • oh, also peer the seer's deposit box will be useable by players after completion of both Fremennik Trials and Easy Diary, so why don't you try and see if it can be properly accessed now also

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits, I did not edit any JSON files by hand (MR will be rejected if there are manual JSON edits).

  • I acknowledge that this contribution will be released under the AGPL license.

Merge request reports