Skip to content

Allow mining and dramen-tree wcing to authentically reward directly after the first tick

Player Name requested to merge PlayerName/2009scape:minespeed into master

What has been done in this MR?

  • Made mining perform a reward roll one tick after the interaction has started. Fixes #1858 fixes #1651. Let's leave #1705 open because the source there shows that we also need to update our animation and text (I'm not doing that in this MR)
  • Made the dramen tree authentically give out a reward after a single tick. Fixes the remaining inauthenticity mentioned in !1683 (merged).
  • Ported the dramen tree listener to an event hook, moving it away from the legacy Java woodcutting implementation to the modern Kotlin one

What should testers check?

  • Mining now SOMETIMES hands out ore immediately, in a way that feels appropriate
  • The dramen tree now always hands out a branch immediately
  • The dramen tree's behavior w.r.t. the Lost City quest is correct. Test with ::setqueststage 83 20 (this is when you fight the tree spirit), less than 20 (nothing should happen in this case, not even a message), more than 20 (this should allow you to chop the tree)
  • Woodcutting anything else should not regress
  • I have tested these changes thoroughly.
  • I used the relevant Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.
Edited by Player Name

Merge request reports