Skip to content

Convert Rimmington to Kotlin

thelemir requested to merge thelemir/2009scape:Rimmington-to-Kotlin into master

What has been done in this MR?

  • Finish implementation of !1637 (closed)
  • Converted all Rimmington NPCs to Kotlin
    • Does not include Chemist, Da Vinci, and others west of the town square
  • Enabled pickpocketing of Anja and Hengel
    • The right click option already existed but did not perform a pickpocket. I added them to the skill handler to fix this
  • Converted the Witch's Potion quest to Kotlin
  • Verified Witch's Potion quest journal and dialogue
    • Quest journal source (play at 0.25 speed with sound off):
    • Quest dialogue source:
      • There's a 3rd option for the dialogue prior to starting the quest "What, you mean improve my magic?" which is out of scope for this MR due to not being able to find the rest of the dialogue for it. Earliest version in the wiki is 2012
    • Item removal at Hetty's dialogue "Ok, now drink from the cauldron." is authentic behavior

What should testers check?

  • Witch's Potion Quest (quest id 31) and quest journal
  • Hetty's dialogue before, during, and after the quest
  • Anja and Hengel interactions
    • Dialogue completes successfully on all options
    • Anja gives you 1-3 coin(s) when you ask for free stuff, Hengel does not
    • They both scream when you threaten to kill them. If one is already dead, then only the alive one screams. Dialogue closes successfully when this happens
    • Able to pickpocket both (Right click -> Pickpocket), behaves like pickpocketing Man/Woman NPCs
  • Brian, archery store - Dialogue works and shop opens
  • Rommik, crafting store - Dialogue works and shop opens
  • Rimmington Shop keeper + assistant - Dialogue works and shop opens
  • Regression test cooking on the range in the building next to Hetty.
    • It was not changed in this MR but the previous MR's tests experienced issues with it. I tested again and was not able to reproduce it locally, but let's have a regression test to confirm it is working correctly.
  • I have tested these changes thoroughly.

  • I used the relevant Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Edited by thelemir

Merge request reports