Skip to content

Fix Bork / Surok instanced area music

Player Name requested to merge PlayerName/2009scape:instance_music into master

What has been done in this MR?

  • Have Bork play The Wrong Path (https://runescape.wiki/w/The_Wrong_Path), in the correct way by setting the music track when the instanced region is created. (Also removed the previous definition in the music configs json, which was incorrect and useless (repairing my own mistake here!).)
  • Have the Surok cutscene in What Lies Below play Surok's Theme, in the correct way by setting the music track when the instanced region is created.
  • For players who already completed What Lies Below, have Surok's Theme unlock when they log in next, as is 2009-authentic (https://runescape.fandom.com/wiki/Surok's_Theme - it turns out that we're really following into Jagex's footsteps here!).

What should testers check?

  • Visit Bork in the Chaos Tunnels. Observe that he plays The Wrong Path.
  • Set quest stage 136 to 70. Give yourself item 11014. Talk to Surok Magis in the Varrock palace library to start the cutscene. Observe that the cutscene has the correct music.
  • Make a new account that has quest stage 136 >70. (Or ::permadeath your existing one.) Log in and observe the music gets unlocked for you.
  • I have tested these changes thoroughly.

  • I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Edited by Player Name

Merge request reports