Skip to content

Grappling Fixes

GregF requested to merge Gregf36665/2009scape:issue1761 into master

What has been done in this MR?

  • Yanille south shortcut is now usable withe mith and higher crossbows (Fix #1761 (closed)).
  • If you do not have the requirements the text should no longer be cut off everywhere (Fix #1679 (closed))
  • Catherbury skill check gives you the right answer (Fix #1768 (closed))
  • Port all grapple shortcuts to kt:
    • Yanille Wall
    • Escape Water Obelisk
    • Catherby rocks
    • Karamja Volcano
    • Falador wall
  • Add Lumbridge to Al Kharid over the River Lum

What should testers check?

  • Check mith (9181), addy (9183), rune (9185) and Dorgeshuun (8880) crossbows work with mith grapple (9419) works at the following sites:
    • Yanille Wall (17047) This should be animated. Check you jump over the correct wall
    • Escape Water Obelisk (17062) This should be animated (incorrectly though).
    • Catherby rocks (17042) This should be animated (incorrectly though).
    • Karamja Volcano (17074).
    • River Lum (17068).
    • Falador wall (17049) AND (17050) This should be animated. 17050 is tough to find. You must be using HD to see it....
    • Dorgesh-Kaan Agility Course is not implemented since Death to the Dorgeshuun is not implemented.

At all locations:

  • Check when lower level than the shortcut the warning is not cut off.
  • Check you cannot use shortcuts without both a bow and the grapple.
  • Unless otherwise specified there are no animations
  • Check the teleport locations are correct.
  • Check that the distance to the grapple target is correct.

Remaining grappling issues I will need help to fix/some guidance

Technically none of these blocks this MR, it's more just to polish off grappling shortcuts.

  1. Should a grapple out of range just say nothing interesting happens? I could not find any source to suggest what it should stay instead.
  2. Should grappling be SOFT?
  3. What animation do the remaining ones need?
  4. How do I reopen the tab the player had open after the fade back from black?
  5. How do I make the wall jump look better?
  • I have tested these changes thoroughly.

  • I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Edited by GregF

Merge request reports