Skip to content

Clean up server name references some more

Player Name requested to merge PlayerName/2009scape:servername into master

What has been done in this MR?

  • Change Rune -> 2009 / ServerConstants.SERVER_NAME where applicable
  • Truncated the obviously incorrectly dumped examine for ridiculously weird item 3241, which now no longer DCs you when you examine it
  • Some unimportant grammar things in the Grand Tree quest's Foreman dialogue since I ran into them anyway
  • Regrettably, all mentions of the RPDT needs to stay the RPDT, because there is an npc named "RPDT Employee" in the cache and his name isn't being overridden by the json (although I did amend it there so that everything that's coming from us is "clean stuff"). However, I did adapt Wizard Cromperty to explain that RPDT stands for the "${ServerConstants.SERVER_NAME} Parcel Delivery Team". The resulting discrepancy is unfortunate, but most players will only talk to this guy once in their life.

What should testers check?

Test that the below all mention "2009Scape":

  • Examine ::item 292, 550, 600, 3241, 4566, 13576 (for the last one, the item name has been adjusted in the JSON but it seems the game is actually pulling it directly from the cache - so this MR can't do anything about it)
  • Destroy ::item 14056
  • Look at the name of ::npc 945
  • Examine ::object [574,575,576,577,578], 1276, [3033,3034,3035,3036], [5791,36749,36751], 8973, 10081, 11356, 11761, [13411,13412], 13526, 13527. Objects in brackets are objects that all share the same id, you can just pick one within each bracket set. The last two objects, 13526 & 13527, refuse to spawn, so I could not test them and neither can you.
  • Read ::item 10999 and ::object 31299
  • Talk to ::npc 674. Say his wife is no longer with us, he loves worm holes, Anita. Note how the guy then mentions gnomes invading "2009Scape".
  • ::setqueststage 71 70. Talk to ::npc 670 to receive four twigs. ::tele 2487 3464 2. Place the twigs in the TUZO pattern, then go down the trapdoor. Note how Glough's speech mentions "2009Scape".
  • (There's one bot dialogue, but the odds of you getting it are small and there are no nontrivialities about it.)
  • Talk to ::npc 2328. Ask him what he's invented. Ask him about the other block. Note that he talks about the "2009Scape" Parcel Delivery Team.
  • I have tested these changes thoroughly.
  • I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.
Edited by Player Name

Merge request reports