Skip to content

Added return amount for "Continue" option on the make set interface

Bonesy requested to merge joshking071/2009scape:set-interface-fix into master

What has been done in this MR?

  • The make set interface now returns the value 1 when the "Continue" option is selected rather than make all.
    • I'm not sure what the button is supposed to actually do and it's on most of make interfaces.
  • Changed the return value to 10 for unhanded button ids as 10 sets is the max you can make.

More Detail:

  • The below image shows the approximate location where the player receives the make 1, 5, or 10 sets options.
    • Standard Make Options.png
  • The next image shows the approximate location where the player receives the continue as option.
  • As button Id for this option is currently doesn't return a value, it falls to else -> handler.getAll(getIndex(handler, buttonId)) , resulting in bolts, arrows, etc. being made until the player has used either all of the input items in their inventory.
    • Continue Option.png

What should testers check?

  • Making sets, i.e broad bolts, makes the amount selected and never exceeds 10 sets.
  • I have tested these changes thoroughly.
  • I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.
Edited by Bonesy

Merge request reports

Loading