Karamja Bug Fixes
What has been done in this MR?
Resolved #1028 (closed) -
- Both NPCs right click options now function.
- Dialogue converted to Kotlin for both NPCs.
- Minor dialogue modifications, mostly for purchasing the skill cape.
- Corrected the coins shown when paying.
Other Changes -
- Converted the Karamja Option Plugin to a Karamja Listener and Brimhaven Listener.
- Removed some duplicated handlers such at the ship yard gate and cart.
- Corrected the coins shown when paying to enter the Brimhaven dungeon.
- Moved achievement diary tasks to the the Karamja and Seers achievements files.
- The palm tree now drops the leaf to the ground when shaken and has an animation.
If some values seem overly documented, this is because they are quest related and I wanted them to be easy to find if someone was adding the quests.
Sources: Shows that a different dialogue option is given at 99 Agility - https://youtu.be/wuVIKwg5bds?t=176 Stack of Coins on dialogue: https://youtu.be/cSgBw5RLboI?t=26 Pay via dialoguge and quick pay option are different -
- Paying via talking - https://www.youtube.com/watch?v=f4Zu4gfmWiQ
- Paying via "Pay" option - https://www.youtube.com/watch?v=Ji3mytZO8P8
Shaking the palm tree (oldest source I could find) - https://youtu.be/Rd87RX6SiSQ?t=1034
What should testers check?
- Karamja easy rewards are still claimable
- Agility cape can be purchased
- Quick options for Cap'n Izzy No-Beard & Pirate Jackie the Fruit work
- Agility arena can be entered after payment
- Brimhaven dungeon can be entered after payment
- Musa Point volcano can be entered and exited
- Seers pick flax diary task can still be completed
- Karamja pick bananas diary task can still be completed
- Karamja palm leaf pick diary task can still be completed
-
I have tested these changes thoroughly. -
I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.