Skip to content

Implement big fish

Player Name requested to merge PlayerName/2009scape:big_fish into master

What has been done in this MR?

  • Big bass, shark, and swordfish are now obtainable from fishing. Fixes #1620 (closed).
  • The message for catching shark now ends with an authentic exclamation mark. Source: https://www.youtube.com/watch?v=CYSa1vxP3bU
  • The fishing skill cape perk now, correctly IMO, also logs catching a second fish in your number of fish caught

What should testers check?

  • That you are able to obtain big bass, shark, swordfish
  • That the messages are correct
  • Anything else (e.g. normal fishing) should not regress

Notes for info:

  • Dev builds have the rate for big fish boosted to 1 in 10 (from 1 in 5000)
  • The fishing skill cape perk will always award a regular fish, even if your primary fishing action had rolled a big one
  • I have tested these changes thoroughly.

  • I used the relevant Thanos/Zaros tool for any JSON edits where possible, and have attached screenshots of any changes.

Edited by Player Name

Merge request reports