Skip to content

Rewrite dialogues to Kotlin and other small fixes.

Trident101 requested to merge Trident101/09-scape-dev:Rewrite-dialogues into master

What have you done in this MR?

  • Fur trader dialogue to Kotlin, changed class name and moved file to a different location;
  • Port Khazard shopkeeper dialogue to Kotlin;
  • Gem merchant dialogue to Kotlin;
  • Baker dialogue to Kotlin;
  • Aemad's & Kortan shop dialogue to Kotlin, removed Kortan's shop and mapped it to Aemad's shop(resource: https://runescape.wiki/w/Kortan?oldid=1333263), change shop stock accordingly (resource: https://runescape.wiki/w/Aemad%27s_Adventuring_Supplies?oldid=2244531)
  • Captain Barnaby dialogue to Kotlin. Oddly enough, the class is mapped to ID 381, while Captain Barnaby's ID is 4974. While talking to ID 4974 it is however using the class where ID 381 is mapped in.

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:
  • I have tested these changes thoroughly.
  • This requires extra testing due to changes to architecture or other similarly risky changes.
  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.
  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports