Skip to content

Fixed Many Issues 2

Zerken requested to merge Zerken/2009-scape-zerken:fix-many-issues-2 into master

What have you done in this MR?

  • Removed 2 bot dialogues that reference summer.

Resolved #1088 (closed) :

  • Shops will no longer charge you gold if your inventory has no space for the item you are buying.

Resolved #1497 (closed) :

  • The ::shop can no longer be opened if the player is movement or interaction locked

Resolved #1392 (closed) : ::rolldrops 187 1000

  • Rogues(ID: 187) now drop the proper coin id(995) instead of 6964

Resolved #1346 (closed) :

  • Rewrote the canoe station chop down as a soft script so you can't interrupt it

Resolved #1323 (closed) :

  • Fixed the player locks for relleka trapped chest
  • Fixed the open animation so it does not play when your inventory is full

Resolved #1372 (closed) :

Resolved #1324 (closed) : ::setqueststage 87 40 , ::setqueststage 87 60 to test the different dialogues you should get

  • Fixed the dialogue for lady of the lake. (Who are you? -> I seek the sword Excalibur)

Resolved #1299 (closed) :

  • The player is now locked and can't interrupt the stepping stone shortcuts

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:
  • I have tested these changes thoroughly.
  • This requires extra testing due to changes to architecture or other similarly risky changes.
  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.
  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Zerken

Merge request reports