Skip to content

Random Event Update 1

Zerken requested to merge Zerken/2009-scape-zerken:random-event-update into master

What have you done in this MR?

  • Implemented smoke puff sound when random event npcs disappear
  • Fixed RandomEventNPC terminate function so it will not it will not play the smokepuff sound and graphic every tick on a finalized event npc when called by tick(). This was causing the sound and graphic to play about 3 times.
  • Fixed the NPCTalkListener to check if a random event npc is finalized. If the npc is finalized(about to disappear) the player will get the chat message "They aren't interested in talking to you.".
  • Admins will no longer get random events

Drill Demon Event: Partialy rewrote the event to be authentic. Video of the event ::revent -p username -e drill_demon

  • The event can no longer be avoided and Sergeant Damien automatically teleports you to the event
  • The player can no longer escape the event by logging out
  • Sergeant Damien now walks around the area in a circle as he should authentically
  • Corrected all of Sergeant Damien's dialogue to be authentic
  • Implemented the authentic item dialogues that show you the picture of the sign to exercise at after Sergeant Damien tells you too
  • Implemented all the exercise sounds

Evil Bob's Island: ::revent -p username -e evil_bob

  • Rewrote all uses of pulses to scripts: Evil bob teleporting you to the island, leaving the island using the portal
  • Fixed evil bob not teleporting you to his island because you are in combat when he tries to teleport you. He will now always teleport the player.
  • Fixed the reward dialogue that the player sees when leaving the island to work authenically

FreakyForester: ::revent -p username -e freaky_forester

  • Rewrote the freaky forester teleport to a script instead of a pulse
  • Fixed an issue where the player the event was for and all nearby players could talk to the freaky forester outside of the event area when he spawns

Genie Event: Rewrote most of the event. ::revent -p username -e genie

  • Resolved #1486
  • The genie now leaves after completing the dialogue
  • Implemented the genie appearing sound

Evil Chicken: ::revent -p username -e evil_chicken

  • Fixed the evil chicken to use the correct attack sound

Misc changes:

  • Added a fun admin command ::barrage [radius] . The new barrage command hits all the players in the radius defines with a custom weak ice barrage. It will play the ice barrage sound, display graphics and hit the player for a random 0-3 damage. A fail safe has been added so the command will hit 0 if the player is low on health so this command will not accidentally kill players. Have fun ceikry.

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:
  • I have tested these changes thoroughly.
  • This requires extra testing due to changes to architecture or other similarly risky changes.
  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.
  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports