Exclude pets from split combat level calculation

Player Namerequested to merge
PlayerName/2009scape:splitcombat-fuckgit into master

What have you done in this MR?

Made it so that only Summoning familiars and not pets cause Summoning to be included in the combat level calculation. Among other things, this makes sure that the correct level revenant will spawn for you in the context of the DW threat system.

Looking at https://web.archive.org/web/20090212134904/http://www.runescape.com/kbase/viewarticle.ws?article_id=2380, Jagex's intent was clearly for Summoning to be included if the player is using, or could be about to use, Summoning to obtain a combat advantage against other players, and for the Summoning level to not be included if this is not the case. Pets do not rely on Summoning nor provide a combat advantage, so they do not fall in the category of familiars that should cause Summoning to be included.

But the source says "familiar" and a pet is a familiar! I'm not sure that it is, but I'm not a semanticist. The following source https://web.archive.org/web/20090201095141/http://news.runescape.com/newsitem.ws?id=1442 is a bit more explicit: "your Summoning is now only counted into your Combat level if you have recently summoned a creature or held a Summoning pouch". Drop-ing a kitten really does not entail Summon-ing it, so if you want to get technical this might be the argument you're looking for. But again, looking beyond semantic technicalities, it seems clear that the intent behind the split combat level was to accurately reflect if the player is an increased PvP danger from utilizing Summoning or not, and pets just do not fall into that category at all.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Player Name

Merge request reports