Rewrite the barrows reward chest

Player Namerequested to merge
PlayerName/2009scape:barrows into master

What have you done in this MR?

  • Rewrite the barrows reward chest according to the very precise drop tables and roll algorithm given at the OSRS wiki. - Reverted
  • Remove inauthentic potions from drop table.
  • Remove the inauthentic restriction that the chest may only be looted after all brothers have been killed - each brother's loot is now added to the rewards dynamically. This means that the chest can be looted with any from 0 to 6 brothers alive/dead.

I think I'm happy with this now, so now it's up to code review and testers. These were the things I struggled with during the draft:

  • OSRS source - Was indeed not acceptable, so reverted to original
  • Couldn't figure out how to combine duplicate item rewards - Managed to do that now
  • First time writing Kotlin -- this is for eg ceik to comment on

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Player Name

Merge request reports