Skip to content

Grafana Integration + Unified SQLite Boilerplate + Fixed bot movement performance regression

Ceikry requested to merge grafana-integration into master

What have you done in this MR?

  • Implemented support for Grafana monitoring of tick times, etc.

    • Toggled on/off via integrations/grafana_logging
    • Path for the sqlite db location configurable via integrations/grafana_log_path
    • Time to keep logs (in days) is configurable via integrations/grafana_log_ttl_days
    • Exported dashboard is included in this MR under Server/db_exports/grafana-dashboard.json Import into grafana and point it to the grafana.db sqlite file.
  • Created a unified base class for managing SQLite connections. Deduplicated lots of code.

  • Fixed a performance regression in bot movement logic

IMPORTANT NOTE: SOME CONFIG OPTION LOCATIONS/NAMES HAVE CHANGED

server/discord_webhook -> integrations/discord_ge_webhook

server/moderation_webhook -> integrations/discord_moderation_webhook

server/openrsc_integration_webhook -> integrations/openrsc_integration_webhook

Testers: Just make sure the GE database still functions: i.e., make sure offers can still be placed and finished, etc.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Ceikry

Merge request reports