Skip to content

Make Teleport to House teleport *into* the house, rather than outside the portal

Player Name requested to merge (removed):housetele into master

What have you done in this MR?

  • Changed Teleport to House to teleport you inside the house, rather than outside. This is the 2009-authentic behavior.
  • Split up entering the POH into three steps (pre-enter, enter, post-enter) to make the above possible (I hope that this was the right approach to this problem, but I am very much open to feedback if a different approach would be better. I'm not too familiar with the code base and its design principles, and I would appreciate any pointers and advice!)
  • Removed HouseTeleportPlugin.java, which turned out to be 100% dead code and was an annoying red herring for me

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:
  • Make sure that entering the house normally continues to work as expected and that normal post-house-entering stuff is fired correctly (e.g. your butler is spawned)
  • Make sure that logging out while inside the house sends you to the front porch, and does not get you stuck in a white void
  • Teletabs use a separate code path from the magic teleport, so make sure things work for both teleport types
  • I have tested these changes thoroughly.
  • This requires extra testing due to changes to architecture or other similarly risky changes.
  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.
  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports