Resolve Infinite Lunar Cast Range

Ceikryrequested to merge
cast-range-fix into master

What have you done in this MR?

  • Improved the ContentAPI hasLineOfSight function to be more accurate (does not affect any existing content)
  • Updated SpellListeners to correctly pathfind within a certain distance of targets with targetable spells, bearing in mind line of sight rules as well.

Testers:

  • Switch to the lunar spellbook
  • Monster Examine, Fertile Soil, any lunar spell which must be cast on a non-item should pathfind the player to a spot within 10 tiles of the target that has line of sight before casting the spell.

Closes #800 (closed)

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports