Only consume daily Ring of the Star Sprite teleport if the teleport actually went through

Player Namerequested to merge
(removed):ring-tele-scam into master

What have you done in this MR?

  • The daily ring of the star sprite teleport charge is now only consumed if the teleport actually happened. This resolves the (IMO) following undesireable scenario:
  1. be in Pest Control boat
  2. use ring to teleport to shooting star
  3. don't get teleported, instead get message that the knights wouldn't appreciate you teleporting out of their boat
  4. leave boat and try again
  5. don't get teleported, be informed "The ring is still recharging"
  6. walk

Ask me how I came up with this one :)

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports