Skip to content

Fixed agility pyramid

Zerken requested to merge Zerken/2009-scape-zerken:fix-agility-pyramid into master

What have you done in this MR?

  • Resolved #1064 (closed) : You can now properly fail the jump and cross gap obstacles

  • Fixed an issue when failing the the 2nd level north cross gap obstacle when going west causing you to get stuck inside the pyramid

  • Fixed jump/cross gap obstacle sounds

  • Fixed moving block obstacle audio so the sliding sound plays for all players within 3-4 tiles of the block when it moves

  • Implemented music/jingle that plays when you get the pyramid top

  • Updated all agility pyramid sounds to use the new playAudio ContentAPI function and constlib.

  • Adjusted gold reward from selling pyramid tops to Simon Templeton based on agility level. GP reward = 1000 + ((agility level / 99) * 9000). The authentic reward to 2009 is 1k GP. Per Ceikry we are changing it to this new calculation to be not be as over powered but still a viable option.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Zerken

Merge request reports