Skip to content

Fixed a bunch of exceptions

Ceikry requested to merge exception-backlog-fixes into master

What have you done in this MR?

  • Fixed a bug that could occasionally cause the sandwich lady interface to become unresponsive
  • Fixed an issue that could cause shade random events to not spawn for max-level players
  • Fixed an issue that could cause zombie random events to not spawn for max-level players
  • Fixed a widespread book issue that resulted from not resetting the current page index when closing a book, and then trying to open another book with less pages.
  • Converted bogrog pouch swap to the generic item select interface, and removed relevant code from the grand exchange code. (Closes #1247 (closed))
  • Fixed an issue that could occasionally prevent exchange of item sets
  • Fixed an issue with Diango's reclaim interface that could result in items other than the ones you clicked being claimed
  • Made incubation moderately more reliable, and incubation timers now pass even while offline (Closes #1264 (closed))
  • Fixed an issue that prevented the leather crafting dialogue from accepting tokenized amounts (e.g. 100k)
  • Fixed an issue that prevented the tool leprechaun interface from allowing tokenized amounts
  • Fixed an issue that prevented players from using tokenized amounts in the ogleroot purchase dialogue for vinesweeper
  • Fixed an issue that prevented Zaff's batttlestaff dialogue from accepting tokenized amounts
  • Fixed an issue that prevented Shop buy-x options from accepting tokenized amounts
  • Various shop-related exception fixes (Closes #1276 (closed))
  • Added some ingame player messages for when a Hunter "catch" option isn't being handled properly
  • Fixed some exceptions being thrown by lunar spells
  • Pyramid Plunder is now better at detecting when a player is in the minigame erroneously and kicking them out
  • Fixed an issue that would lead to incorrect Kalphite Queen behavior when killing her with multiple players in the room
  • Fixed an issue that could cause the Bedabin Nomad's dialogue to hang during Tourist Trap
  • Fixed several more issues with Fight Arena cutscenes
  • Fixed an issue that could prevent the dwarf dialogue from opening while trying to enter the mountain shortcut before finishing Fishing Contest
  • Fixed an issue that could cause dialogue option hangs in certain unusual circumstances
  • Fixed an issue that could result in non-movement for interactions where the override location was the same as the target node's location and there was no destination flag set
  • Fixed an issue where setting invalid node data could cause issues with NPC rendering
  • Server can now detect when a session is sending up multiple invalid packets and automatically disconnect the player
  • Fixed an issue that could lead to unintended saving of varps/varbits
  • Fixed an issue that could cause some interactions in shops to silently fail. The user will now receive a relevant message when these situations occur.
  • Users may now find they could occasionally receive a very snarky response when incorrectly using commands.
  • Users now receive messages when they try to make use of unimplemented friends/clan/etc features.
  • Errors in string parsing will no longer result in "dead" inputs when attempting to add friends/update clan ranks/etc
  • Fixed an issue that could lead to loss of some alerts in the Discord integration. Discord integration will now detect problems and queue the failed messages to be resent later.
  • Added more safety checks to item-on-grounditem packet handling to prevent throwing exceptions
  • Exceptions in string parsing for command packets will now inform the user that something went wrong, and ask them to try again.
  • Improved drop table parsing and fixed incorrect drop tables (Closes #1281 (closed))

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Ceikry

Merge request reports