Skip to content

Hunter sounds update

Zerken requested to merge Zerken/2009-scape-zerken:hunter-sounds-update into master

What have you done in this MR?

  • Implemented setup, dismantle, and catching sound for bird snares
  • Implemented setup, dismantle, and catching sound for box traps
  • Implemented setup, dismantle, and catching sound for net traps
  • Implemented setup, dismantle, and catching sound for dead falls
  • Implemented setup and dismantle sound for rabbit snares
  • Implemented butterfly net swing sound
  • Implemented falconry fly and catch sound
  • Implemented noose sound when catching kebbits
  • Implemented setup, dismantle, catching, teasing, jumping over, and npc jumping over pitfall sound to pitfalls
  • Implemented appropriate player lock time to setting up net traps and deadfalls to avoid players from interrupting the action
  • Implemented appropriate player lock time to dismantling bird snares, box traps, net traps, rabbit snares and deadfalls to avoid players from interrupting the action
  • Implemented a new function for AudioManager.java with a location parameter

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports