Skip to content

Implement the thieving skillcape.

Oven Bread requested to merge ovenbreado/2009scape:thieving-skillcape-takeover into master

Check in on behalf of @RGamberini on !948 (closed). Looks like a simple fix that got abandoned, but seems authentic.

From his list:

  • Implemented the thieving skillcape perk as according to the 2009scape website
  • Fixed the skill roll calculation
  • Removed the pickpocketing buff from H.A.M robes. (See tweet from JMod Ash)
  • Applied the thieving skillcape perk to the pickpocket action

I made a few small changes:

  • Made SMOOTH_HANDS +25 to reflect https://2009scape.org/site/game_guide/skill_cape_perks.html -> "Your expertise with pickpocketing makes you much harder to detect. 25% lower chance to fail a pickpocket."
  • Made SkillcapePerks.SMOOTH_HANDS & GLOVES_OF_SILENCE_10075 additive.
  • Fixed the shite thieving skillcape dialogue.

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:

This one seems hard to test since it's just diceroll effects. Try wearing the skillcape and check to see if thieving rolls are better. I did test this and it feels better?, but my luck sucks.

It does affect the thieving skill though. Hopefully its not super game changing.

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Oven Bread

Merge request reports