Skip to content

Requirements Audit

Ceikry requested to merge authenticity-audit into master

What have you done in this MR?

  • Added a new quest requirement system that allows more things to be fairly unlockable while putting existing things behind fair and authentic requirements (BOTH skill requirements AND quest requirements, when applicable)

  • EVERYTHING that should be quest locked should now be so

  • EVERYTHING that has been implemented is 100% EARNABLE, there is nothing locked behind impossible requirements.

  • Things that should have higher requirements than what is currently possible will have those requirements increase as more quests are added, automatically.

  • The prereqs for any quest can be viewed at any time by simply clicking it in the quest list.

  • Things that were freely available but are now locked include:

    • Sophanem now requires/requires the prereqs of Icthlarin's Little Helper
    • Pharaoh's Sceptre requires the same^
    • Equipping god books now requires Horror from the Deep/its prereqs
    • Neitiznot helmet now requires the Fremennik Isles prereqs rather than just Fremennik Trials
    • Cape of Legends now correctly requires the full possible prereqs for Legend's Quest rather than just 55 QP
    • Dragon Scimitar now correctly requires the Monkey Madness prereqs
    • Ape Atoll teleport now correctly requires the Monkey Madness prereqs
    • Slayer Helmet and the Slayer Rewards Shop in general now correctly require the Smoking Kills prereqs (not high)
    • Dragon Halberd now requires the Regicide prereqs
    • Climbing Boots now require the Death Plateau prereqs
    • Dragon SQ Shield now requires the Legend's Quest prereqs to equip (source available in sourcecode)
    • Initiate Armour now requires the Recruitment Drive prereqs
    • Proselyte Armour now requires the Slug Menace prereqs
    • Access to Piscatoris now requires the Swan Song prereqs (effectively Quest Cape here.)
    • The disease-free herb patch in Trollheim now requires the My Arm's Big Adventure prereqs.
    • Ardougne Teleport now requires the Plague City prereqs
    • Watchtower Teleport now requires the Watchtower prereqs
    • Trollheim Teleport now requires the Eadgar's Ruse prereqs
    • The Lunar spellbook now requires the Lunar Diplomacy prereqs
    • The Ancient spellbook now requires the Desert Treasure prereqs
    • Crafting Astral Runes now requires the Lunar Diplomacy prereqs
    • Crafting Death Runes now requires the Mourning's End Part II prereqs
    • Crafting Blood Runes now requires the Legacy of Seergaze prereqs
    • Access to Cave Horrors now requires the Cabin Fever prereqs
    • Sorceress' Garden now requires Prince Ali Rescue
    • Access to the Heroes' Guild now requires the Heroes' Quest prereqs
    • Access to GWD now requires the Troll Stronghold prereqs
    • Access to Neitiznot and Jatizso now requires Fremennik Trials
    • Access to Shilo Villa now requires the Shilo Village prereqs
    • The Keldagrim cart system now requires The Giant Dwarf prereqs
    • Fairy Rings now require the full Fairy Tale I - Growing Pains prereqs
    • Ectophial now requires the Ghosts Ahoy prereqs
    • Access to Tormented Demons now requires the While Guthix Sleeps prereqs (basically quest cape here)
    • Access to the Halberd Shop and the ability to equip Dragon Halberds now requires the Regicide prereqs
    • Access to Lletya now requires the Mourning's End Part I prereqs
    • Access to Corporeal Beast now requires the Summer's End prereqs
    • Chivalry and Piety prayers now require the King's Ransom prereqs
    • Ali Morrisane's rune shop now requires the The Feud prereqs
    • Armoured Zombies now require the Defender of Varrock prereqs
    • Experiments now require the Creature of Fenkenstrain prereqs
    • The carpet to Sophanem now requires the Icthlarin's Little Helper prereqs
    • The carpet to Uzer now requires The Golem
    • The carpet to Bedabin Camp now requires The Tourist Trap
    • The bank in Sophanem now requires the Contact! prereqs
    • The Dragon Battleaxe now requires the prereqs of Heroes' Quest to equip.
    • The Dragon Mace now requires the prereqs of Heroes' Quest to equip.
    • Spirit shields of all varieties (improved, blessed, unblessed) now require the prereqs of Summer's End to equip.
    • Bork access now requires What Lies Below

  • Things that were previously locked/unavailable but are now available (with prereqs) are:

    • It is now possible to obtain and equip Barrow's Gloves with the Recipe for Disaster prereqs.
    • It is now possible to obtain and equip an Ancient Staff with the Desert Treasure prereqs.
    • It is now possible to enchant your secateurs into Magic Secateurs with the Fairy Tale I - Growing Pains prereqs and 40k gold
    • It is now possible to equip the Ancient Mace with the Another Slice of H.A.M prereqs
    • It is now possible to get Suqahs as a task from Duradel with the Lunar Diplomacy prereqs
    • It is now possible to obtain a Seal of Passage by speaking with Chieftan Brundt after meeting the Lunar Diplomacy prereqs
    • It is now possible to obtain Ancient Staves by killing the level 96 and 103 mummies in the Ancient Pyramid (1/500)

Additionally, this opens up the floor for us to slowly introduce some more things at our discretion while keeping their access fair (as I have done above with Magic Secateurs)

Testers: Please go through the list I have provided above and verify that the requirements exist and prevent you from accessing/using the content. Also, please make sure I haven't missed anything.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Ceikry

Merge request reports