Skip to content

Player Stock Improvements

Ceikry requested to merge playerstock-recirculation into master

What have you done in this MR?

  • Player Stock is now cleared from the general store at an interval defined by world.playerstock_clear_mins (defaults to 180 minutes)
  • Player Stock can now be recirculated back onto the GE as bot offers when cleared if world.playerstock_bot_offers is true (defaults to true)

This MR attempts to tackle the issue of player stock on the live server constantly being full. It also provides an optional benefit of bolstering bot stock with the items that otherwise would have been completely deleted from the game.

This bonus is not exploitable because in every possible scenario, the offered bot price on the GE will be higher than the price it was sold to the shop for, even at high alch shops.

@ryannathans Test Server - Please set playerstock_clear_mins to something reasonable like 1-5 to make testing this easier for testers

Testers:

  • Sell an item to player stock
  • Eventually the item should disappear from player stock, and reappear on the GE as bot stock.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports