Skip to content

Reorganize, expand, and make corrections to the Sheep Shearer quest

zsrv requested to merge zsrv/2009scape:sheep-shearer-quest into master

What have you done in this MR?

  • Make the sheep-shearer:wool attribute a saved attribute so the balls of wool delivered by a player aren't lost if the player logs out
  • Reorganize, expand, and make corrections to Fred the Farmer/Sheep Shearer quest dialogue

Most corrections are sourced from YouTube videos uploaded in 2009. Any dialogue with a FacialExpression that has been changed from HALF_GUILTY has been seen in a video. FredTheFarmer dialogue stage 1300 was sourced from an OSRS Wiki transcript: https://oldschool.runescape.wiki/w/Transcript:Sheep_Shearer?oldid=12551566

Other sources/notes:

https://www.youtube.com/watch?v=tnITBfckYR4 (uploaded 2008-04-17):

  • Quest journal displayed after starting quest, before making wool (with 0 balls of wool in inventory); shows the full struck out text that is being updated
  • "Fred! Fred! I've seen The Thing!" dialogue triggered

https://www.youtube.com/watch?v=JzFbdX0wztA (uploaded 2008-07-16):

  • "Fred! Fred! I've seen The Thing!" dialogue triggered

https://www.youtube.com/watch?v=br9a7-z4Is8&t=87s (uploaded 2008-08-25):

  • Journal: "I have enough balls of wool to give Fred and get my reward money!"

https://www.youtube.com/watch?v=br9a7-z4Is8&t=100s (uploaded 2008-08-25):

  • Adjusted dialogue options when penguin sheep was never sheared

https://www.youtube.com/watch?v=B6oZ1SfweAA (uploaded 2008-09-22):

  • Slower clicks through dialogue to check facial expressions
  • Sheared the penguin sheep

https://www.youtube.com/watch?v=oqwJWG9W47Q (uploaded 2008-10-15):

  • Quest journal displayed after starting quest, before and after making wool into balls (with 0 and 20 balls of wool in inventory)
  • Quest tab opened at the point the quest is marked as complete (shows when the quest turns green)
  • Quest journal text "I need to collect 20 more balls of wool" has the number of balls colored blue (the number is colored red in a 2009-02-20 video)

https://www.youtube.com/watch?v=_6vmKUvOEn4 (uploaded 2009-01-13):

  • Shows the quest journal before the quest is started
  • Triggers "Err. No I don't know actually" dialogue with shears in inventory (doesn't know how to shear a sheep)
  • Triggers "Fred! Fred! I've seen The Thing!" dialogue

https://www.youtube.com/watch?v=bSV7wJuFxfA (uploaded 2009-02-11):

  • Quest journal displayed before starting quest
  • Slower clicks through dialogue to check facial expressions
  • Quest journal displayed immediately after starting quest
    • "I need to collect 20 more balls of wool."
  • Less than 20 balls of wool delivered at once
  • Quest journal is open at the point the quest is marked as started/in progress

https://www.youtube.com/watch?v=88UNz64XbBo (uploaded 2009-02-20):

  • Quest journal text that is struck out after starting the quest reads "I asked Fred the Farmer, near Lumbridge, for a quest. Fred" "said he'd pay me for shearing his sheep for him!"
  • Quest journal text "I need to collect 20 more balls of wool" has the number of balls colored RED (this fact might be useful for when the target game version is moved forward)

https://www.youtube.com/watch?v=qir1h3gr-I8&t=70s (uploaded 2009-02-21):

  • Triggers "I don't know how to spin wool, sorry." dialogue, shows the spinning wheel message with the map icon

https://www.youtube.com/watch?v=EGkYfL8Iwcc (uploaded 2009-03-16):

  • Follows "Err. No, I don't know actually" dialogue path without shears in inventory (triggers dialogue different than when shears are already in inventory)
  • Triggers "I don't know how to spin wool, sorry." dialogue
  • Quest journal text that is struck out after starting the quest has changed
  • Quest journal text "I need to collect 20 more balls of wool" has the number of balls colored RED (this fact might be useful for when the target game version is moved forward)
  • Triggers "Fred! Fred! I've seen The Thing!" dialogue

https://www.youtube.com/watch?v=jKqdGGmptmU (uploaded 2009-04-27):

  • Triggers "Err. No, I don't know actually." dialogue when asked "Good! Now one more thing, do you actually know how to shear a sheep?" with shears already in inventory

https://www.youtube.com/watch?v=5Ew7vW4X8pA (uploaded 2009-06-27):

  • Has sounds playing

https://www.youtube.com/watch?v=u8yFibe7pWw (uploaded 2009-07-12):

  • Displays quest journal after the quest is complete, extra lines added

https://www.youtube.com/watch?v=Nqgua38WLYc (uploaded 2009-07-13):

  • Quest doesn't turn green until the quest complete message appears, contrary to earlier behavior

https://www.youtube.com/watch?v=fAAUQg5A0ho (uploaded 2009-07-21):

  • Quest doesn't turn yellow until the dialogue ends, contrary to earlier behavior

https://www.youtube.com/watch?v=KDGsqH8ItPc (uploaded 2009-08-18):

  • Follows "Err. No, I don't know actually" dialogue path without shears in inventory (triggers dialogue different than when shears are already in inventory)
  • Triggers "I don't know how to spin wool, sorry." dialogue

https://www.youtube.com/watch?v=ccBYAPszhI8 (uploaded 2009-09-19):

  • Sounds enabled

https://www.youtube.com/watch?v=TMeNgQUjnKg (uploaded 2009-09-21):

  • Triggers "What do you mean, The Thing?" dialogue

https://www.youtube.com/watch?v=0LUw5b7sXq8 (uploaded 2009-10-18):

  • Triggers dialogue when quest has been started, owes balls of wool, only has wool in inventory

https://www.youtube.com/watch?v=AvVLcclZ7Yk (uploaded 2009-11-03):

  • Quest journal displayed after starting the quest, before delivering any balls of wool (number of wool to collect is in red)

https://www.youtube.com/watch?v=kGZ0FuNaWe8 (uploaded 2009-11-16):

  • Clicks nice and slow through the dialogue (for chat head animation checking)

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports