Skip to content

Implement ScrollInterface and created KnightsNotes as proof of concept.

Oven Bread requested to merge ovenbreado/2009scape:scroll-listener-helper into master

What have you done in this MR?

  • Created a new ScrollInterface similar to BookInterface
  • Implement KnightsNotes (::item 11734)
  • Some cleanup to BookInterface

I wanted to use the Knight's Notes as the initial proof of concept because all players will receive it before entering the GWD.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports