Skip to content

NPC/Player render flag refactor + Improved force movement API

Ceikry requested to merge flags-refactor into master

What have you done in this MR?

  • Completely rewrote all the logic, encoding, etc for player/npc rendering masks (Animations, force movements, etc.)
  • Groundwork for modular 578 support has now been laid (at least in regards to render masks)
  • Introduced an improved and more accurate API for using force movement (the old API is still around, and I have marked all of its methods as deprecated.)
  • Converted a couple example cases to using the new API just as a proof of concept
  • Added a method to our tick/time conversion methods to convert client cycles <-> ticks
  • Added all authentically-named buffer read/write methods to the server's buffer class

Testers:

  • Just generally play the game, make sure chat, forced chat, animations, graphics, face {entity, location}, etc all appear to work correctly.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Ceikry

Merge request reports