Skip to content

Refactor DestroyItemPlugin into DropListener

Oven Bread requested to merge ovenbreado/2009scape:refactor-destroy-listener into master

What have you done in this MR?

  • Refactor DestroyItemPlugin into DropListener
  • Update DropListener to use more of the ContentAPI

As long as you can destroy items, this should be good.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Oven Bread

Merge request reports