Skip to content

Impling + Puro Puro Rewrite

Ceikry requested to merge implingrework into master

What have you done in this MR?

  • Completely ripped out old impling system and replaced it with a new one that is actually authentic
  • No more static impling spawns (fixes exploitable behavior)
  • Implings spawn at the correct odds
  • Puro Puro has been reworked
    • Now has authentic spawn counts
    • Now has authentic rare impling rates
    • Now has authentic impling mechanics
    • Imp defenders should now function correctly (chance of removing lowest tier impling you have, scales by thieving level.)
    • Imp repellent should make it harder for imp defenders to release your implings.
    • Removed a bunch of incorrect wheat wilting points
    • Wheat wilting/growing within the maze now correctly animates
    • Crop Circles now appear randomly throughout the world
  • Fixed #343 (closed)

Testers:

  • Make sure implings spawn!
  • You should be able to bind, snare, entangle implings to stop them from moving
  • You can use ::implings to look at the list of currently active implings (including when they are in their invisible spawner roam state - the names will be HighTier, MidTier, etc....) (DOES NOT INCLUDE PURO PURO IMPLINGS)
  • Implings should globally respawn/reshuffle roughly every 30 minutes (excluding puro puro)
  • Implings should not respawn outside of the above cycle (excluding puro puro)
  • There should now be about ~40 static spawns of low-tier implings in puro puro that respawn within (7, 40) ticks
  • The high tier implings in puro puro only appear in the northwest/southeast corners and appear pretty slowly
  • Impling defenders should have a chance of releasing the lowest-tier impling in your inventory when you are near them.
  • Imp repellent should decrease the chance of impling defenders succeeding at releasing implings
  • Crop circles should remember where you entered from, so when you exit puro puro (even after a relog) you appear where you entered from.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Ryan

Merge request reports