Skip to content

Fix inauthentic cooking

RiL requested to merge RiL0/2009scape:fix-inauthentic-cooking into master

What have you done in this MR?

  • Fixed inauthentic cooking success chances (fire, range, cooking gauntlets, lumbridge range).
  • Fixed numerous other cooking related issues.
  • Fixed #1138 (closed).

Are there any tricky things testers should keep an eye out for?

  • Yes, as follows: This is genuinely impossible to exhaustingly test due to this MR correcting the success chance of every single food in the game. You would need to cook hundreds of every food, for every single cooking level, then see if it matches established success chances. But frankly that would be a waste of time, because with an authentic success formula (which we have), and correct success values (low/high, which you can check in the code), it will give a 100% correct success chance. I think the only possible "test" for this MR is a thorough look into the code changes, and if not wanting to double check all food values, just trust that I got them correct. :)

  • I have tested these changes thoroughly.

  • I acknowledge that this contribution will be released under the AGPL license.

Edited by RiL

Merge request reports