Skip to content

Merge Diango Items into Toy Listeners

Oven Bread requested to merge ovenbreado/2009scape:diango-item-convert into master

What have you done in this MR?

  • Merge the only two toys in DiangoItems into Toy Listeners. This was quite bad as this plugin used to listen out for "spin" and "fly" options globally without specifying which item it was. The only two items are SPINNING_PLATE_4613 and TOY_KITE_12844. Spinning plate animation was also fixed as there are two consecutive animation that happens when spinning it.

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports