Skip to content

Generalized all books into a common interface. Modified StatsCommandSet to use...

Oven Bread requested to merge ovenbreado/2009scape:bookread-option-listener-convert into master

What have you done in this MR?

  • Implemented a generic book interface
  • Converted StatsCommandSet to use the new book interface (Required as it steals the current interface listener for one of the books)
  • Worked on #230 conversion of interaction/item/BookreadOption

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:

Please double check that ::stats playername works as usual. Slight changes to title and pages numbering. Please help check if the code is generally good to be done for other interfaces. I may copy this style of callbacks for other interfaces down the line.

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports