Skip to content

Optimise and refactor container checks

RiL requested to merge RiL0/2009scape:optimise-container-checks into master

What have you done in this MR?

  • Optimised, fixed and refactored container (bank/inventory/equipment) checks
  • I believe I've tested it pretty well. I haven't found anything different.
  • Because the re-ordering in ContentAPI could get confusing for diff, here are the functions I did non trivial changes to or added:
  • amountInBank, getAmountInBank, amountInEquipment, inBank, inEquipment,

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by RiL

Merge request reports