Skip to content

Unify decanting into one rewritten and well-oiled handler

Ceikry requested to merge unify-decanting into master

What have you done in this MR?

  • Rewrote decanting into a simplified and flexible ContentAPI method
  • Replaced Zahur's separate method of decanting with the new unified method
  • Replaced Bob Barter's (or whatever the herblore NPC in the GE's name is) separate method of decanting with the new unified method

Closes #910 (closed)

Closes #1124 (closed)

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Merge request reports