Skip to content

Address some lingering issues

Ceikry requested to merge additional-assorted-bugfixes into master

What have you done in this MR?

  • Fixed some error spam about a nullref in animateWoodcutting
  • Fixed a general script processing oversight that could cause error-throwing scripts to continue executing
  • Scripts being processed now automatically cancel if the interaction-target-node is no longer active (fixes object could not be replaced spam)
  • Fixed the stopExecuting() spam
  • Fixed a CME in the disconnection queue (only affected server shutdown)
  • Future-proofed the ground spawn parser to work with the format Zaros now outputs
  • Added in proper SKILLING global clock for use with the script system - addresses some quirks and brings us closer to authenticity (closes #1122)

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Ceikry

Merge request reports