Skip to content

Resolve "teleport to house teleports to back of portal if the house is in Yanille", add command, misc bugfixes.

Sam requested to merge scholar_nz/2009scape:1070-teletab-listener-conversion into master

What have you done in this MR?

  • Fixes #1070 (closed)
  • Resolves confidential issue #1073
  • Converts from plugin to listener: Teleport Tab & Teleport Home Tab
  • Adds new ::runekit command, which gives a Tester 1k of each Rune type, to make magic testing easier.

Are there any tricky things testers should keep an eye out for?

  • Yes, as follows:
  • Construction Lectern functionality should still work completely. Ensure you are testing the creation of various Magic Tabs as part of your test scope.
  • Bones to Peaches Tabs require testing, which is present in a character's save as the flag: "bonesToPeaches":true,. This may need to be enabled on test to complete effective testing.

Test Scope:

Test 1 - Functionality Testing

  • Obtain teleport tabs. Test that teleporting functions correctly, and items are decremented as appropriate.

  • Item IDs:

    • 8008 through to 8013.

  • Test ::runekit - Does it give you the appropriate runes?

  • Test if issue #1073 is fixed.

Test 2 - Regression Testing

  • Obtain non-teleport tabs. Ensure their functionality remains correct.
  • Item IDs:
    • 8014 through to 8022

Test 3 - Refactor Testing

  • Build Study / Lectern in Construction of max level. Build both the Demon AND Eagle Mahogany Lecterns to test the full range:
  • image
  • Obtain all types of magic tabs.

Accessory items required:

  • Bone Item IDs: 526, 532, 534, 536
  • Something to Telekenetic Grab
  • Jewellery to enchant (e.g Necklaces). IDs: 1656, 1658, 1660, 1662, 1664, 6577.
  • Soft Clay and runes to use to make Magic Tablets: 1761, ::runekit

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Closes #1070 (closed)

Edited by Sam

Merge request reports