Skip to content

Fishing partial rewrite

bushtail requested to merge bushtail/2009dev:crawfish-boil into master

What have you done in this MR?

  • rewrote contents of global/skill/fishing, with some changes to global/skill/gather/fishing
  • also added crayfish catching

Are there any tricky things testers should keep an eye out for?

  • No
  • Yes, as follows:
  • Make sure fishing spots don't walk around.
  • Make sure fishing spots give the right fish.
  • Make sure fishing spots are in the right spot for the type; this means compared to Live. This should not be a regression.

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by bushtail

Merge request reports