Skip to content

Various Characters Fixups 2

Skal Fate requested to merge archive_2009scape/Server-2009scape:Various_Characters_2 into master

What have you done in this MR?

  • Various Characters Fixups. Mostly grammar fixups.
  • Dialogue Animations Fix: Dorics Quest, Omglewip in WizzardsTower,
  • Sawmill Operator options handler is now kotlin listener and also fixes unreachable bug,
  • Mining Guild Entrance Dwarf grammar fix,
  • Farsight Seer had expression and grammar fix,
  • Zeke of alkharid had grammar fix,
  • Chompy bird had grammar fix,
  • Prince Ali,
  • MineCart Driver,
  • Reldo with lost tribe now ends dialogue correctly when talks about the book.

Animation_-_PortSarim_Thaki_the_DeliveryDwarf_Dialogue_AnimationsAnimation_WizzardsTowerDialogue_-_Lost_Tribe_Reldo_Please_wait_foreverDialogue_-_The_Tourist_Trap_Cart_DriverMining_Guild_Dwarf_-_Dialogue_errorQuest_-_Dorics_Quest_frozen_animationQuest_Text_-_Prince_Ali_RequeQuests_-_Big_Chompy_Bird_Hunting_DialogueText_-_AlKharidZeke_double_toText_-_SeerVillageVarrock_-Sawmill_Operator-_no_dialogue_and_trade_takes_4_steps_back

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Skal Fate

Merge request reports