Skip to content

Various Characters around Runescape are better expressing themselves and have...

Skal Fate requested to merge archive_2009scape/Server-2009scape:VariousCharacters into master

What have you done in this MR?

  • Various Characters around Geilnor have fixed their grammar errors in their Dialogues and their expressions :

  • Lumbridge: Explorer Jack Grammar errors, Fishng Tutor expressions, Prayer Tutor expressions.

  • Falador:

  • Make over Mage has had her expressions fixed.

  • Castle squire dialogue error where he self refrences himself 2x in acheivement diary dialogue.

  • Rising Sun Bartenders Dialogue more happier.

  • Varrock:

  • Thessalia Expressions , Head Chef expressions

  • Taverly:

  • Kaquemeex and Sanfew has had his expressions changed to be more accurate.

  • Port Sarim:

  • [Bug]: Thaki The Dwarf dialogue was sending a bad player expression causing it to break animation.

  • Bartender.

  • Klarence from DragonSlayer has had some updated expressions. The source is a bit newer but no reason to see the expressions changed.

  • Rimmington:

  • Hetty has had some expressions restored.

  • Karmaja:

  • Luthas from Pirates Treasure had some expressions changed and dialogue added.

  • [Bug]: Man character spoke the players dialogues. Fixed.

  • Brimhaven:

  • Bartender Expressions

  • Davon the amulet seller expressions

  • Sources :

  • Make-over Mage https://youtu.be/-vrwP2fu9r8?t=44 || https://youtu.be/GCmJgBksS3c?t=53

  • Hetty: https://youtu.be/e-jQN7RQ9nU?t=15

  • Luthas: Pirates Treasure: https://www.youtube.com/watch?v=4EFQdG443fw || https://www.youtube.com/watch?v=d4QREZSw6fY

  • Klarense https://youtu.be/sZsbLYH8ZFc?t=61

  • Cooking Guild Chef: https://www.youtube.com/watch?v=-pNTylVIJsI

  • Other various videos on bartenders.

Dialogue_-_Karmaja_Man

Are there any tricky things testers should keep an eye out for?

  • No

  • Yes, as follows:

  • I have tested these changes thoroughly.

  • This requires extra testing due to changes to architecture or other similarly risky changes.

  • I used the Thanos Tool for any JSON edits where possible, and have attached screenshots of any changes.

  • I acknowledge that this contribution will be released under the AGPL license.

*** NOTE: If Gitlab complains about pipelines stating that you need to "Validate your Gitlab account" there is no need to worry. You do not have to do this and it is only occurring because OUR pipeline tried to run on your fork. While it's preferred that you do validate your account, you can safely ignore/dismiss this message from Gitlab. ***

Edited by Skal Fate

Merge request reports